add normal3x.c filter and fix the normal algorithm problem

app/src/main/cpp/gfx/video_filters/normal2x.c

@@ -99,76 +99,54 @@ static void normal2x_generic_destroy(void *data)
    free(filt);
 }
 
-static void normal2x_work_cb_xrgb8888(void *data, void *thread_data)
-{
-   struct softfilter_thread_data *thr = (struct softfilter_thread_data*)thread_data;
-   const uint32_t *input              = (const uint32_t*)thr->in_data;
-   uint32_t *output                   = (uint32_t*)thr->out_data;
-   uint32_t in_stride                 = (uint32_t)(thr->in_pitch >> 2);
-   uint32_t out_stride                = (uint32_t)(thr->out_pitch >> 2);
-   uint32_t x, y;
-
-   for (y = 0; y < thr->height; ++y)
-   {
-      uint32_t *out_ptr = output;
-      for (x = 0; x < thr->width; ++x)
-      {
-         uint32_t row_color[2];
-         uint32_t *out_line_ptr = out_ptr;
-         uint32_t color         = *(input + x);
-
-         row_color[0]           = color;
-         row_color[1]           = color;
-
-         /* Row 1 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr          += out_stride;
-
-         /* Row 2 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-
-         out_ptr += 2;
-      }
-
-      input  += in_stride;
-      output += out_stride << 1;
-   }
+static void normal2x_work_cb_xrgb8888(void *data, void *thread_data) {
+    struct softfilter_thread_data *thr = (struct softfilter_thread_data *) thread_data;
+    const uint32_t *input = (const uint32_t *) thr->in_data;
+    uint32_t *output = (uint32_t *) thr->out_data;
+    uint32_t in_stride = (uint32_t) (thr->in_pitch >> 2);
+    uint32_t out_stride = (uint32_t) (thr->out_pitch >> 2);
+    uint32_t x, y;
+
+    for (y = 0; y < thr->height; ++y) {
+        uint32_t *out_ptr = output;
+
+        // row 1
+        for (x = 0; x < thr->width; ++x) {
+            out_ptr[0] = out_ptr[1] = *(input + x);
+            out_ptr += 2;
+        }
+
+        // row 2
+        memcpy(out_ptr, output, out_stride);
+
+        input += in_stride;
+        output += out_stride << 1;
+    }
 }
 
-static void normal2x_work_cb_rgb565(void *data, void *thread_data)
-{
-   struct softfilter_thread_data *thr = (struct softfilter_thread_data*)thread_data;
-   const uint16_t *input              = (const uint16_t*)thr->in_data;
-   uint16_t *output                   = (uint16_t*)thr->out_data;
-   uint16_t in_stride                 = (uint16_t)(thr->in_pitch >> 1);
-   uint16_t out_stride                = (uint16_t)(thr->out_pitch >> 1);
-   uint16_t x, y;
-
-   for (y = 0; y < thr->height; ++y)
-   {
-      uint16_t *out_ptr = output;
-      for (x = 0; x < thr->width; ++x)
-      {
-         uint16_t row_color[2];
-         uint16_t *out_line_ptr = out_ptr;
-         uint16_t color         = *(input + x);
-
-         row_color[0]           = color;
-         row_color[1]           = color;
-
-         /* Row 1 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr          += out_stride;
-
-         /* Row 2 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-
-         out_ptr               += 2;
-      }
-
-      input                    += in_stride;
-      output                   += out_stride << 1;
-   }
+static void normal2x_work_cb_rgb565(void *data, void *thread_data) {
+    struct softfilter_thread_data *thr = (struct softfilter_thread_data *) thread_data;
+    const uint16_t *input = (const uint16_t *) thr->in_data;
+    uint16_t *output = (uint16_t *) thr->out_data;
+    uint16_t in_stride = (uint16_t) (thr->in_pitch >> 1);
+    uint16_t out_stride = (uint16_t) (thr->out_pitch >> 1);
+    uint16_t x, y;
+
+    for (y = 0; y < thr->height; ++y) {
+        uint16_t *out_ptr = output;
+
+        // row1
+        for (x = 0; x < thr->width; ++x) {
+            out_ptr[0] = out_ptr[1] = *(input + x);
+            out_ptr += 2;
+        }
+
+        // row 2
+        memcpy(out_ptr, output, out_stride);
+
+        input += in_stride;
+        output += out_stride << 1;
+    }
 }
 
 static void normal2x_generic_packets(void *data,

app/src/main/cpp/gfx/video_filters/normal3x.c

@@ -0,0 +1,237 @@
+/*  RetroArch - A frontend for libretro.
+ *  Copyright (C) 2010-2014 - Hans-Kristian Arntzen
+ *  Copyright (C) 2011-2018 - Daniel De Matteis
+ *
+ *  RetroArch is free software: you can redistribute it and/or modify it under the terms
+ *  of the GNU General Public License as published by the Free Software Found-
+ *  ation, either version 3 of the License, or (at your option) any later version.
+ *
+ *  RetroArch is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
+ *  without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+ *  PURPOSE.  See the GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License along with RetroArch.
+ *  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/* Compile: gcc -o normal3x.so -shared normal3x.c -std=c99 -O3 -Wall -pedantic -fPIC */
+
+#include "softfilter.h"
+#include <stdlib.h>
+#include <string.h>
+
+#ifdef RARCH_INTERNAL
+#define softfilter_get_implementation normal3x_get_implementation
+#define softfilter_thread_data normal3x_softfilter_thread_data
+#define filter_data normal3x_filter_data
+#define generic_input_fmts normal3x_generic_input_fmts
+#define generic_output_fmts normal3x_generic_output_fmts
+#define generic_threads normal3x_generic_threads
+#define generic_create normal3x_generic_create
+#define generic_output normal3x_generic_output
+#define generic_destroy normal3x_generic_destroy
+#define work_cb_xrgb8888 normal3x_work_cb_xrgb8888
+#define work_cb_rgb565 normal3x_work_cb_rgb565
+#define generic_packets normal3x_generic_packets
+#define generic normal3x_generic
+#endif
+
+struct softfilter_thread_data {
+    void *out_data;
+    const void *in_data;
+    size_t out_pitch;
+    size_t in_pitch;
+    unsigned colfmt;
+    unsigned width;
+    unsigned height;
+    int first;
+    int last;
+};
+
+struct filter_data {
+    unsigned threads;
+    struct softfilter_thread_data *workers;
+    unsigned in_fmt;
+};
+
+static unsigned generic_input_fmts(void) {
+    return SOFTFILTER_FMT_XRGB8888 | SOFTFILTER_FMT_RGB565;
+}
+
+static unsigned generic_output_fmts(unsigned input_fmts) {
+    return input_fmts;
+}
+
+static unsigned generic_threads(void *data) {
+    struct filter_data *filt = (struct filter_data *) data;
+    return filt->threads;
+}
+
+static void *generic_create(
+        const struct softfilter_config *config,
+        unsigned in_fmt, unsigned out_fmt,
+        unsigned max_width, unsigned max_height,
+        unsigned threads, softfilter_simd_mask_t simd,
+        void *userdata
+) {
+    struct filter_data *filt = (struct filter_data *) calloc(1, sizeof(*filt));
+    if (!filt)
+        return NULL;
+    if (!(filt->workers = (struct softfilter_thread_data *) calloc(
+            1,
+            sizeof(struct softfilter_thread_data)))) {
+        free(filt);
+        return NULL;
+    }
+    /* Apparently the code is not thread-safe,
+     * so force single threaded operation... */
+    filt->threads = 1;
+    filt->in_fmt = in_fmt;
+    return filt;
+}
+
+static void generic_output(
+        void *data,
+        unsigned *out_width, unsigned *out_height,
+        unsigned width, unsigned height
+) {
+    *out_width = width << 1;
+    *out_height = height << 1;
+}
+
+static void generic_destroy(void *data) {
+    struct filter_data *filt = (struct filter_data *) data;
+    if (!filt)
+        return;
+    free(filt->workers);
+    free(filt);
+}
+
+static void work_cb_xrgb8888(void *data, void *thread_data) {
+    struct softfilter_thread_data *thr = (struct softfilter_thread_data *) thread_data;
+    const uint32_t *input = (const uint32_t *) thr->in_data;
+    uint32_t *output = (uint32_t *) thr->out_data;
+    uint32_t in_stride = (uint32_t) (thr->in_pitch >> 2);
+    uint32_t out_stride = (uint32_t) (thr->out_pitch >> 2);
+    uint32_t x, y;
+
+    for (y = 0; y < thr->height; ++y) {
+        uint32_t *out_ptr = output;
+
+        /* Row 1 */
+        for (x = 0; x < thr->width; ++x) {
+            out_ptr[0] = out_ptr[1] = out_ptr[2] = *(input + x);
+            out_ptr += 3;
+        }
+
+        /* Row 2 */
+        memcpy(out_ptr, output, out_stride);
+        out_ptr += out_stride;
+
+        /* Row 3 */
+        memcpy(out_ptr, output, out_stride);
+
+        input += in_stride;
+        output += out_stride * 3;
+    }
+}
+
+static void work_cb_rgb565(void *data, void *thread_data) {
+    struct softfilter_thread_data *thr = (struct softfilter_thread_data *) thread_data;
+    const uint16_t *input = (const uint16_t *) thr->in_data;
+    uint16_t *output = (uint16_t *) thr->out_data;
+    uint16_t in_stride = (uint16_t) (thr->in_pitch >> 1);
+    uint16_t out_stride = (uint16_t) (thr->out_pitch >> 1);
+    uint16_t x, y;
+
+    for (y = 0; y < thr->height; ++y) {
+        uint16_t *out_ptr = output;
+
+        /* Row 1 */
+        for (x = 0; x < thr->width; ++x) {
+            out_ptr[0] = out_ptr[1] = out_ptr[2] = *(input + x);
+            out_ptr += 3;
+        }
+
+        /* Row 2 */
+        memcpy(out_ptr, output, out_stride);
+        out_ptr += out_stride;
+
+        /* Row 3 */
+        memcpy(out_ptr, output, out_stride);
+
+        input += in_stride;
+        output += out_stride * 3;
+    }
+}
+
+static void generic_packets(
+        void *data,
+        struct softfilter_work_packet *packets,
+        void *output, size_t output_stride,
+        const void *input, unsigned width, unsigned height,
+        size_t input_stride
+) {
+    /* We are guaranteed single threaded operation
+     * (filt->threads = 1) so we don't need to loop
+     * over threads and can cull some code. This only
+     * makes the tiniest performance difference, but
+     * every little helps when running on an o3DS... */
+    struct filter_data *filt = (struct filter_data *) data;
+    struct softfilter_thread_data *thr = (struct softfilter_thread_data *) &filt->workers[0];
+
+    thr->out_data = (uint8_t *) output;
+    thr->in_data = (const uint8_t *) input;
+    thr->out_pitch = output_stride;
+    thr->in_pitch = input_stride;
+    thr->width = width;
+    thr->height = height;
+
+    if (filt->in_fmt == SOFTFILTER_FMT_XRGB8888)
+        packets[0].work = work_cb_xrgb8888;
+    else if (filt->in_fmt == SOFTFILTER_FMT_RGB565)
+        packets[0].work = work_cb_rgb565;
+    packets[0].thread_data = thr;
+}
+
+static const struct softfilter_implementation generic = {
+        generic_input_fmts,
+        generic_output_fmts,
+
+        generic_create,
+        generic_destroy,
+
+        generic_threads,
+        generic_output,
+        generic_packets,
+
+        SOFTFILTER_API_VERSION,
+        "normal3x",
+        "normal3x",
+};
+
+const struct softfilter_implementation *
+softfilter_get_implementation(
+        softfilter_simd_mask_t simd
+) {
+    return &generic;
+}
+
+#ifdef RARCH_INTERNAL
+#undef softfilter_get_implementation
+#undef softfilter_thread_data
+#undef filter_data
+#undef softfilter_get_implementation
+#undef softfilter_thread_data
+#undef filter_data
+#undef generic_input_fmts
+#undef generic_output_fmts
+#undef generic_threads
+#undef generic_create
+#undef generic_output
+#undef generic_destroy
+#undef work_cb_xrgb8888
+#undef work_cb_rgb565
+#undef generic_packets
+#undef generic
+#endif

app/src/main/cpp/gfx/video_filters/normal4x.c

@@ -99,96 +99,70 @@ static void normal4x_generic_destroy(void *data)
    free(filt);
 }
 
-static void normal4x_work_cb_xrgb8888(void *data, void *thread_data)
-{
-   struct softfilter_thread_data *thr = (struct softfilter_thread_data*)thread_data;
-   const uint32_t *input              = (const uint32_t*)thr->in_data;
-   uint32_t *output                   = (uint32_t*)thr->out_data;
-   uint32_t in_stride                 = (uint32_t)(thr->in_pitch >> 2);
-   uint32_t out_stride                = (uint32_t)(thr->out_pitch >> 2);
-   uint32_t x, y;
-
-   for (y = 0; y < thr->height; ++y)
-   {
-      uint32_t *out_ptr = output;
-      for (x = 0; x < thr->width; ++x)
-      {
-         uint32_t *out_line_ptr = out_ptr;
-         uint32_t color         = *(input + x);
-         uint32_t row_color[4];
-
-         row_color[0] = color;
-         row_color[1] = color;
-         row_color[2] = color;
-         row_color[3] = color;
-
-         /* Row 1 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr += out_stride;
-
-         /* Row 2 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr += out_stride;
-
-         /* Row 3 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr += out_stride;
-
-         /* Row 4 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-
-         out_ptr += 4;
-      }
-
-      input  += in_stride;
-      output += out_stride << 2;
-   }
+static void normal4x_work_cb_xrgb8888(void *data, void *thread_data) {
+    struct softfilter_thread_data *thr = (struct softfilter_thread_data *) thread_data;
+    const uint32_t *input = (const uint32_t *) thr->in_data;
+    uint32_t *output = (uint32_t *) thr->out_data;
+    uint32_t in_stride = (uint32_t) (thr->in_pitch >> 2);
+    uint32_t out_stride = (uint32_t) (thr->out_pitch >> 2);
+    uint32_t x, y;
+
+    for (y = 0; y < thr->height; ++y) {
+        uint32_t *out_ptr = output;
+
+        /* Row 1 */
+        for (x = 0; x < thr->width; ++x) {
+            out_ptr[0] = out_ptr[1] = out_ptr[2] = out_ptr[3] = *(input + x);
+            out_ptr += 4;
+        }
+
+        /* Row 2 */
+        memcpy(out_ptr, output, out_stride);
+        out_ptr += out_stride;
+
+        /* Row 3 */
+        memcpy(out_ptr, output, out_stride);
+        out_ptr += out_stride;
+
+        /* Row 4 */
+        memcpy(out_ptr, output, out_stride);
+
+        input += in_stride;
+        output += out_stride << 2;
+    }
 }
 
-static void normal4x_work_cb_rgb565(void *data, void *thread_data)
-{
-   struct softfilter_thread_data *thr = (struct softfilter_thread_data*)thread_data;
-   const uint16_t *input              = (const uint16_t*)thr->in_data;
-   uint16_t *output                   = (uint16_t*)thr->out_data;
-   uint16_t in_stride                 = (uint16_t)(thr->in_pitch >> 1);
-   uint16_t out_stride                = (uint16_t)(thr->out_pitch >> 1);
-   uint16_t x, y;
-
-   for (y = 0; y < thr->height; ++y)
-   {
-      uint16_t *out_ptr = output;
-      for (x = 0; x < thr->width; ++x)
-      {
-         uint16_t row_color[4];
-         uint16_t *out_line_ptr = out_ptr;
-         uint16_t color         = *(input + x);
-
-         row_color[0] = color;
-         row_color[1] = color;
-         row_color[2] = color;
-         row_color[3] = color;
-
-         /* Row 1 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr += out_stride;
-
-         /* Row 2 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr += out_stride;
-
-         /* Row 3 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-         out_line_ptr += out_stride;
-
-         /* Row 4 */
-         memcpy(out_line_ptr, row_color, sizeof(row_color));
-
-         out_ptr += 4;
-      }
-
-      input  += in_stride;
-      output += out_stride << 2;
-   }
+static void normal4x_work_cb_rgb565(void *data, void *thread_data) {
+    struct softfilter_thread_data *thr = (struct softfilter_thread_data *) thread_data;
+    const uint16_t *input = (const uint16_t *) thr->in_data;
+    uint16_t *output = (uint16_t *) thr->out_data;
+    uint16_t in_stride = (uint16_t) (thr->in_pitch >> 1);
+    uint16_t out_stride = (uint16_t) (thr->out_pitch >> 1);
+    uint16_t x, y;
+
+    for (y = 0; y < thr->height; ++y) {
+        uint16_t *out_ptr = output;
+
+        /* Row 1 */
+        for (x = 0; x < thr->width; ++x) {
+            out_ptr[0] = out_ptr[1] = out_ptr[2] = out_ptr[3] = *(input + x);
+            out_ptr += 4;
+        }
+
+        /* Row 2 */
+        memcpy(out_ptr, output, out_stride);
+        out_ptr += out_stride;
+
+        /* Row 3 */
+        memcpy(out_ptr, output, out_stride);
+        out_ptr += out_stride;
+
+        /* Row 4 */
+        memcpy(out_ptr, output, out_stride);
+
+        input += in_stride;
+        output += out_stride << 2;
+    }
 }
 
 static void normal4x_generic_packets(void *data,

app/src/main/cpp/griffin/griffin.c

@@ -929,6 +929,7 @@ FILTERS
 #include "../gfx/video_filters/normal2x.c"
 #include "../gfx/video_filters/normal2x_width.c"
 #include "../gfx/video_filters/normal2x_height.c"
+#include "../gfx/video_filters/normal3x.c"
 #include "../gfx/video_filters/normal4x.c"
 #include "../gfx/video_filters/scanline2x.c"
 #include "../gfx/video_filters/grid2x.c"